chore: get lakeprof upload url from env var - #14355
Conversation
|
!bench |
|
Benchmark results for d6c2533 against 8006bb0 are in. There are significant results. @Garmelon Warning These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.
New metrics (2✅, 3🟥)
Large changes (1🟥)
Small changes (4🟥)
|
61d6c4a to
874ae3b
Compare
|
Mathlib CI status (docs):
|
|
Reference manual CI status:
|
MohammedAlkindi
left a comment
There was a problem hiding this comment.
This looks like a good opt-in/configurability change. One coordination question before approval:
tests/bench_build.sh still calls tests/bench/build/lakeprof_report_upload.py unconditionally at the end of the radar build benchmarking flow. Since this script previously uploaded to https://speed.lean-lang.org/lean4-out/{sha} by default, merging this PR will make production lakeprof uploads silently stop unless radar's CI/config is updated to set, for example:
LAKEPROF_UPLOAD_URL=https://speed.lean-lang.org/lean4-out
Has that matching radar change already been made or planned alongside this PR?
This PR allows the bench repo to decide whether and where to upload the lakeprof report. This brings this bench suite more in-line with the others like mathlib's or cslib's.
874ae3b to
65ad36b
Compare
|
!bench |
|
Benchmark results for 65ad36b against 501e4e8 are in. There are significant results. @Garmelon
Small changes (2✅, 1🟥)
|
65ad36b to
b14fda5
Compare
|
!bench |
|
Benchmark results for b14fda5 against 501e4e8 are in. No significant results found. @Garmelon
Medium changes (1✅)
Small changes (3✅, 1🟥)
|
This PR allows the bench repo to decide whether and where to upload the lakeprof report. This brings this bench suite more in-line with the others like mathlib's or cslib's.