perf: avoid unnecessary modifyEnv - #14354
Conversation
|
!bench |
|
Benchmark results for c05ce98 against 4c1cf2f are in. There are significant results. @leodemoura
Large changes (4✅, 1🟥)
Medium changes (14✅)
and 1 hidden Small changes (348✅, 3🟥) Too many entries to display here. View the full report on radar instead. |
This PR implements a minor optimization at `withExporting/withoutExporting`. When they call `modifyEnv` to toggle `Environment.isExporting`, and `MonadEnv` `MetaM`'s `modifyEnv` wipes all `Core` and `Meta` caches. chore: use `old`
|
!bench |
|
Benchmark results for 4680969 against da19ea0 are in. There are significant results. @leodemoura
Large changes (7✅)
Medium changes (12✅)
and 1 hidden Small changes (349✅, 4🟥) Too many entries to display here. View the full report on radar instead. |
|
!bench mathlib |
|
Benchmark results for leanprover-community/mathlib4-nightly-testing@d4f5e49 against leanprover-community/mathlib4-nightly-testing@d87691e are in. There are significant results. @leodemoura Warning These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.
Large changes (8✅)
and 1 hidden Medium changes (36✅) Too many entries to display here. View the full report on radar instead. Small changes (189✅) Too many entries to display here. View the full report on radar instead. |
|
Reference manual CI status:
|
|
Mathlib CI status (docs):
|
This PR implements a minor optimization at
withExporting/withoutExporting. When they callmodifyEnvto toggleEnvironment.isExporting, andMonadEnvMetaM'smodifyEnvwipes allCoreandMetacaches.