fix: enforce set notation per-element indentation - #14350
Merged
Merged
Conversation
github-actions
Bot
added
toolchain-available
leanprover-bot
added
the
builds-manual
Collaborator
|
Reference manual CI status:
|
mathlib-lean-pr-testing
Bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
Kha
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jul 10, 2026
Kha
marked this pull request as ready for review
July 10, 2026 13:47
mathlib-lean-pr-testing
Bot
added
builds-mathlib
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jul 10, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jul 10, 2026
MohammedAlkindi
left a comment
MohammedAlkindi
left a comment
There was a problem hiding this comment.
This change makes sense to me; I left one small test-coverage question inline.
| otherwise could be either a two-field structure or a singleton set, which seems way too confusing | ||
| even when the elaborator can disambiguate the two. | ||
| -/ | ||
| syntax "{" withPosition(term),+ "}" : term |
There was a problem hiding this comment.
Could we add a small regression test for the ambiguous multiline case from the comment? Since this changes user-visible parser/indentation behavior, a test that the { aaa\n bbb } shape is rejected or parsed the intended way would help lock this down for the formatter work. There are related strict-indent tests under tests/elab_fail/byStrictIndent.lean, though any parser test location you prefer is fine.
mhuisi
approved these changes
Aug 21, 2026
Kha
added
the
awaiting-mathlib
Kha
enabled auto-merge
August 25, 2026 09:19
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Aug 25, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Aug 25, 2026
mathlib-lean-pr-testing
Bot
removed
the
awaiting-mathlib
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enforces that elements of singleton notation need to indent e.g. nested application arguments, as otherwise the overlap with structure notation is simply too confusing for both humans and the upcoming formatter (would require blocking on elaboration).