feat: clarify warning for semireducible definitions of class type - #14196
Merged
datokrat merged 11 commits intoJul 13, 2026
Merged
Conversation
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 26, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jun 26, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jun 26, 2026
|
Mathlib CI status (docs):
|
datokrat
force-pushed
the
paul/instance-reducibility-warning
branch
from
July 8, 2026 07:12
48844ae to
7ed8c34
Compare
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 8, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jul 8, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jul 8, 2026
datokrat
force-pushed
the
paul/instance-reducibility-warning
branch
from
July 9, 2026 13:12
2340ab4 to
869476d
Compare
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 9, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jul 9, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jul 9, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jul 10, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jul 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jul 10, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jul 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jul 10, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jul 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jul 10, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jul 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jul 10, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jul 10, 2026
datokrat
marked this pull request as ready for review
July 10, 2026 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves on the warnings and errors regarding reducibility attributes. Partially addresses #13351.
semireducibleattribute, do not claim it is the default; it is not in the case ofinstancedeclarations.@[irreducible] instancedeclarations, in analogy to how we do not warn onattribute [instance] irreducibleDecl.