Skip to content

feat(Padics): add an instance IsValuativeTopology ℚ_[p] - #42998

Open
WenrongZou wants to merge 2 commits into
leanprover-community:masterfrom
WenrongZou:ValuativeRel_Qp
Open

feat(Padics): add an instance IsValuativeTopology ℚ_[p]#42998
WenrongZou wants to merge 2 commits into
leanprover-community:masterfrom
WenrongZou:ValuativeRel_Qp

Conversation

@WenrongZou

@WenrongZou WenrongZou commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

In this PR, we prove an instance IsValuativeTopology ℚ_[p]. Then we have the instance IsNonarchimedeanLocalField ℚ_[p].


Open in Gitpod

@github-actions github-actions Bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

PR summary b0d6ade587

Import changes exceeding 2%

% File
+17.80% Mathlib.NumberTheory.Padics.ValuativeRel

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.NumberTheory.Padics.ValuativeRel 1843 2171 +328 (+17.80%)
Import changes for all files
Files Import difference
Mathlib.NumberTheory.Padics.ValuativeRel 328

Declarations diff (regex)

+ instance : IsValuativeTopology ℚ_[p] := by
+ norm_lt_norm_iff_mulValuation_lt
+ norm_lt_zpow_iff_mulValuation_lt_exp

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- unavailable)

⚠️ No declarations diff yet: there is no built master snapshot at this PR's merge-base (typically a bors-batch intermediate that CI never built). Merge master into this PR and push to refresh.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit b0d6ade587
Reference commit 1f29011071

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Aug 21, 2026
@WenrongZou WenrongZou changed the title feat(Padics): IsValuativeTopology ℚ_[p] feat(Padics): add an instance IsValuativeTopology ℚ_[p] Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant