Skip to content

[Merged by Bors] - chore(CategoryTheory/EssentiallySmall): lower priority of the Category (Shrink C) instance - #42981

Closed
dennj wants to merge 1 commit into
leanprover-community:masterfrom
dennj:shrink-preorder-category-priority
Closed

[Merged by Bors] - chore(CategoryTheory/EssentiallySmall): lower priority of the Category (Shrink C) instance#42981
dennj wants to merge 1 commit into
leanprover-community:masterfrom
dennj:shrink-preorder-category-priority

Conversation

@dennj

@dennj dennj commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Lower the priority of the induced Category (Shrink C) instance below Preorder.smallCategory, so a small preorder's Shrink gets its category structure from its preorder, with morphisms in Type w rather than Type v.

See #42925

@dennj dennj changed the title chore(CategoryTheory/EssentiallySmall): lower priority of the Categor… chore(CategoryTheory/EssentiallySmall): lower priority of the Category (Shrink C) instance Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

PR summary a63170f293

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ instance (priority := 50) [Small.{w} C] : Category.{v} (Shrink.{w} C)
- instance [Small.{w} C] : Category.{v} (Shrink.{w} C)

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit a63170f).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit a63170f293
Reference commit dc30148764

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, but I need a category theorist to sign off.

maintainer merge?

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 20, 2026
@joelriou

Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Aug 20, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 20, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Aug 20, 2026
…y (Shrink C) instance (#42981)

Lower the priority of the induced Category (Shrink C) instance below Preorder.smallCategory, so a small preorder's Shrink gets its category structure from its preorder, with morphisms in Type w rather than Type v.


See #42925
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Aug 20, 2026
@mathlib-bors

mathlib-bors Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore(CategoryTheory/EssentiallySmall): lower priority of the Category (Shrink C) instance [Merged by Bors] - chore(CategoryTheory/EssentiallySmall): lower priority of the Category (Shrink C) instance Aug 20, 2026
@mathlib-bors mathlib-bors Bot closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants