Skip to content

feat(Data/Sym/Sym2): the first element of s(x, x) is x - #42980

Open
YaelDillies wants to merge 1 commit into
leanprover-community:masterfrom
YaelDillies:sym2_fst_out_mk_self
Open

feat(Data/Sym/Sym2): the first element of s(x, x) is x#42980
YaelDillies wants to merge 1 commit into
leanprover-community:masterfrom
YaelDillies:sym2_fst_out_mk_self

Conversation

@YaelDillies

Copy link
Copy Markdown
Contributor

This is useful for simp.

From FormalConjectures


Open in Gitpod

This is useful for simp.

From FormalConjectures
@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

PR summary a4a1181979

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ fst_out_mk_self
+ snd_out_mk_self

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit a4a1181).

  • +2 new declarations
  • −0 removed declarations
+Sym2.fst_out_mk_self
+Sym2.snd_out_mk_self

No changes to strong technical debt.

No changes to weak technical debt.

Current commit a4a1181979
Reference commit b3e74c51c0

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants