Skip to content

feat(LinearAlgebra/Matrix): diagonal matrices with nonnegative entries are totally nonnegative - #42978

Open
sqrt-of-2 wants to merge 1 commit into
leanprover-community:masterfrom
sqrt-of-2:Matrix.IsTotallyNonneg.diagonal
Open

feat(LinearAlgebra/Matrix): diagonal matrices with nonnegative entries are totally nonnegative#42978
sqrt-of-2 wants to merge 1 commit into
leanprover-community:masterfrom
sqrt-of-2:Matrix.IsTotallyNonneg.diagonal

Conversation

@sqrt-of-2

Copy link
Copy Markdown
Contributor

This follow-up PR was suggested by @Vierkantor in #41813 (comment).

This contribution was created during "Formalizing Mathematics in Lean" held in Utrecht in August 2026.

Open in Gitpod

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Aug 20, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

PR summary deca326651

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ IsTotallyNonneg.diagonal
+ IsTotallyNonneg.diagonal_const

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- stale, waiting for the new build)

Lean-aware diff — post-build, computed from the Lean environment (commit deca326).

  • +2 new declarations
  • −0 removed declarations
+Matrix.IsTotallyNonneg.diagonal
+Matrix.IsTotallyNonneg.diagonal_const

No changes to strong technical debt.

No changes to weak technical debt.

Current commit deca326651
Reference commit d77ef0741c

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Aug 20, 2026
@sqrt-of-2
sqrt-of-2 force-pushed the Matrix.IsTotallyNonneg.diagonal branch from 46519aa to deca326 Compare August 20, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant