[Merged by Bors] - chore(Algebra/QuadraticAlgebra): rename Discr to Discriminant - #42975
[Merged by Bors] - chore(Algebra/QuadraticAlgebra): rename Discr to Discriminant#42975xroblot wants to merge 2 commits into
Conversation
PR summary 405e37b9a2Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
Thanks! Can you split this PR in two - one doing the rename, the other adding the module deprecation? This makes for a much cleaner git diff. |
|
Done, Sorry about that. This PR is now just the rename, a pure git mv, and the deprecated_module shim is split out into #42976, which depends on this one. |
|
Thanks! |
|
#42976 is now stacked on #42975: both are in a linked bundle and merge in the same batch, or not at all. The batch applies #42975's changes first (#42976's own changes). Each pull request still needs its own View this bundle in bors (sign in with GitHub to view). |
1 similar comment
|
#42976 is now stacked on #42975: both are in a linked bundle and merge in the same batch, or not at all. The batch applies #42975's changes first (#42976's own changes). Each pull request still needs its own View this bundle in bors (sign in with GitHub to view). |
|
Thanks! Now, bors should merge both PRs in the same batch. |
|
🕐 Waiting for approval ( View this bundle in bors (sign in with GitHub to view). |
Every discriminant file in mathlib spells the word out, `RingTheory/Discriminant.lean`, `Algebra/QuadraticDiscriminant.lean`, `Algebra/CubicDiscriminant.lean`, etc., so `QuadraticAlgebra/Discr.lean` is renamed to match. The declaration `QuadraticAlgebra.discr` is unchanged, following `Algebra.discr`. Prepared with Claude Code 🤖
Re-adds `Mathlib/Algebra/QuadraticAlgebra/Discr.lean` as a `deprecated_module` shim redirecting to the renamed `Discriminant` module (see #42975). Prepared with Claude Code 🤖
|
Pull request successfully merged into master. Build succeeded:
|
Every discriminant file in mathlib spells the word out,
RingTheory/Discriminant.lean,Algebra/QuadraticDiscriminant.lean,Algebra/CubicDiscriminant.lean, etc., soQuadraticAlgebra/Discr.leanis renamed to match. The declarationQuadraticAlgebra.discris unchanged, followingAlgebra.discr.Prepared with Claude Code 🤖