fix(ProfiniteGrp): simplify explicit limit projections - #42971
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary f63edb52e3Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
This pull request is now in draft mode. No active bors state needed cleanup. While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like |
|
Hello from the triage team! Can you comment on whether you used AI for this project? Thanks! |
|
AI (OpenAI Codex) was used extensively for this PR. It was used to:
The final changes were reviewed through the resulting diff and verified locally with |
|
@grunweg Thanks — I’ve added the requested AI-use disclosure above. Is anything else needed from me, or can the |
|
Per the AI policy, the AI disclosure should be mentioned in the PR description (and this PR labelled LLM-generated). Can you do so, please? (While you're at it, please also take a look at the commit message guidelines. For instance, the entire "tested with" part is superfluous.) Thanks! Once you have done this, you can comment |
|
Thanks — done. I added the AI disclosure to the PR description and removed the LLM-generated |
The naturality proof for
ProfiniteCompletion.liftpreviously needed a brittle pointwisechange. The underlying problem was that simplification crossed several semireducible diagram/forgetful-functor boundaries at once, producing terms that are definitionally equal but no longer type-correct at implicit transparency.This PR:
quotientMapusing the diagram object types and maps it through the existingFiniteGrp ⥤ ProfiniteGrpforgetful functor;ProfiniteCompletion.liftnaturality through that API while keeping the limit point bundled, removing the problematic pointwisechange.AI disclosure
AI (OpenAI Codex) was used extensively for this PR. It was used to:
dsimpfailed;ProfiniteGrpAPI simplification andProfiniteCompletion.liftproof changes;The final changes were reviewed through the resulting diff and verified locally.