Skip to content

refactor(Data/Multiset): rename map_filter' - #42970

Open
yuanyi-350 wants to merge 1 commit into
leanprover-community:masterfrom
yuanyi-350:rename-multiset-map-filter
Open

refactor(Data/Multiset): rename map_filter'#42970
yuanyi-350 wants to merge 1 commit into
leanprover-community:masterfrom
yuanyi-350:rename-multiset-map-filter

Conversation

@yuanyi-350

@yuanyi-350 yuanyi-350 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

The deprecated alias was removed in #21271.

@yuanyi-350
yuanyi-350 requested a review from Vierkantor August 20, 2026 02:50
@yuanyi-350 yuanyi-350 added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

PR summary 9a1225ad70

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ map_filter

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 9a1225a).

  • +1 new declarations
  • −0 removed declarations
+Multiset.map_filter

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 9a1225ad70
Reference commit ffbfefaec6

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label Aug 20, 2026

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants