Skip to content

feat(LinearAlgebra/ConvexSpace): StdSimplex bind operation - #38758

Closed
TBUGTB wants to merge 4 commits into
leanprover-community:masterfrom
TBUGTB:stdsimplex-api
Closed

feat(LinearAlgebra/ConvexSpace): StdSimplex bind operation#38758
TBUGTB wants to merge 4 commits into
leanprover-community:masterfrom
TBUGTB:stdsimplex-api

Conversation

@TBUGTB

@TBUGTB TBUGTB commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Define the monadic bind operation for StdSimplex and add basic API lemmas. This operation is needed for formalising the Komlós lemma used in the construction of Stochastic Integrals (cf. this PR in the brownian-motion project).


@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 30, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown

PR summary 5b5173e00f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ bind
+ bind_const
+ bind_single
+ sum_map
+ support_subset_support_bind
+ weights_bind

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 30, 2026
@RemyDegenne RemyDegenne added the brownian Part of the ongoing formalization of the Brownian motion and stochastic integrals label Apr 30, 2026
Comment thread Mathlib/LinearAlgebra/ConvexSpace.lean Outdated
Comment thread Mathlib/LinearAlgebra/ConvexSpace.lean Outdated
Comment thread Mathlib/LinearAlgebra/ConvexSpace.lean Outdated
Comment thread Mathlib/LinearAlgebra/ConvexSpace.lean Outdated
Comment thread Mathlib/LinearAlgebra/ConvexSpace.lean Outdated
Comment thread Mathlib/LinearAlgebra/ConvexSpace.lean Outdated
@EtienneC30 EtienneC30 added the awaiting-author A reviewer has asked the author a question or requested changes. label May 1, 2026
@TBUGTB

TBUGTB commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 1, 2026
@EtienneC30

Copy link
Copy Markdown
Member

Can you resolve the conversations when you applied a suggestion please? This makes the page easier to read.

@EtienneC30

Copy link
Copy Markdown
Member

Thanks!
maintainer merge

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by EtienneC30.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 1, 2026

@RemyDegenne RemyDegenne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label May 1, 2026
@YaelDillies

YaelDillies commented May 1, 2026

Copy link
Copy Markdown
Contributor

Please instead use iConvexCombo once #37592 is merged

@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 1, 2026
@YaelDillies

Copy link
Copy Markdown
Contributor

bors r-

@mathlib-bors

mathlib-bors Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Canceled.

Address comments or fix if necessary, and then someone with permission can run bors r+.

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 2, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

This PR/issue depends on:

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 11, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@YaelDillies

Copy link
Copy Markdown
Contributor

Sorry, I thought #37592 would be merged within a few days... At any rate, I am claiming that iConvexCombo from that PR replaces StdSimplex.bind from this one, so IMO you can close this on and adapt brownian-motion to use iConvexCombo instead.

@TBUGTB

TBUGTB commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

okay, thanks for letting me know

@TBUGTB TBUGTB closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) brownian Part of the ongoing formalization of the Brownian motion and stochastic integrals merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants