public key: add ssz impl - #12
Conversation
b-wagn
left a comment
There was a problem hiding this comment.
Thanks LGTM!
Only minor criticism I have is that we now use fields in the generalized XMSS file, which breaks a bit our abstractions. I wonder if it makes sense to require that encode and decode are defined for the parameter and hash type of the tweakable hash and then call those black-box here. Then move the encoding of field vectors into the tweakable hash file.
Not sure, just an idea.
Okay, so I tried to fix this with the best possible abstraction using a With this new abstraction, it should be super easy to build other SSZ implementations in follow-up pull requests for secret key and signature objects. |
Related #11