Remove special handling for LuaTeX in \genfrac - #2174
Open
zauguin wants to merge 1 commit into
Open
Conversation
Collaborator
|
This would be related to #432 I suppose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READ ME FIRST: Please understand that in most cases we will not be able to merge a pull request because there are a lot of internal activities needed when updating the LaTeX2e sources. If you have a code suggestion please discuss it with the team first.
In \genfrac there is special handling for XeTeX and LuaTeX to avoid
\overwithdelimsand friends. The LuaTeX replacement is provided since "the relevant font dimen parameters are often not set in luatex as there are no matching values in the OpenType Math table". The replacement code conditionally uses the relevant font dimensions and tries to fallback to other logic if they are unset. The fallback code is completely broken. Triggering it manually fails with! Missing font identifiersince a scaling factor is passed when a font identifier is expected. Looking at the git history suggests that it never worked. We could try to fix it, but since noone complained about\binomand friends being completely broken in LuaTeX in the last decade it seems safe to assume that the font parameter is always set in practice. Therefore we can use\overwithdelimsand friends directly. (Also if the font parameter does turn out to be missing in many cases we can start generating it in luaotfload.)Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated