Skip to content

Cuda energy tally patch - #341

Open
jacob-moore22 wants to merge 3 commits into
mainfrom
CUDA_Energy_tally_patch
Open

Cuda energy tally patch#341
jacob-moore22 wants to merge 3 commits into
mainfrom
CUDA_Energy_tally_patch

Conversation

@jacob-moore22

Copy link
Copy Markdown
Collaborator

Description

Two small bug fixes in the multiphysics app:

  1. Missing device update in region/material setup (region_fill.cpp): material_state_setup updated State.MaterialToMeshMaps.elem_in_mat_elem on the device but was missing the corresponding update_device() call for State.MeshtoMaterialMaps.mat_elems_in_elem. This left the mesh-to-material map stale on device (relevant for CUDA/GPU builds), which could cause incorrect material lookups on device.
  2. Malformed PVD file breaks ParaView reading (mesh_io.hpp): the entries written to the .pvd collection file had a stray leading space before the time attribute (time= "..." instead of time="...") and used a wider %12.5e format that padded values with leading spaces. This produced malformed XML attributes that ParaView failed to parse correctly. Changed both timestep and time to use %.5e and removed the extra space so the file loads cleanly in ParaView.

Type of change

Please select all relevant options

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Formatting and/or style fixes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A : Regression test with OpenMP and CUDA.
  • Test B :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant