feat(langsmith): support internal service URL overrides - #804
Draft
Philippe (Pckool) wants to merge 1 commit into
Draft
feat(langsmith): support internal service URL overrides#804Philippe (Pckool) wants to merge 1 commit into
Philippe (Pckool) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds opt-in internal service URL overrides for LangSmith's core configuration and frontend reverse-proxy routes.
Why
The chart currently embeds Kubernetes service FQDNs in core environment variables and NGINX upstreams. This is normally correct, but deployments with custom DNS, service meshes, or alternate internal routing need to direct these calls elsewhere.
Changes
internalServiceUrls, an empty-by-default map of internal endpoint overrides.Validation
helm lint charts/langsmith -f charts/langsmith/ci/lightweight-config-values.yamlhelm unittest charts/langsmith(63 tests)proxy_passretains a Kubernetes service FQDN.main; outputs are byte-identical.