Skip to content

feat(langsmith): support internal service URL overrides - #804

Draft
Philippe (Pckool) wants to merge 1 commit into
langchain-ai:mainfrom
Pckool:agent/langsmith-internal-service-overrides
Draft

feat(langsmith): support internal service URL overrides#804
Philippe (Pckool) wants to merge 1 commit into
langchain-ai:mainfrom
Pckool:agent/langsmith-internal-service-overrides

Conversation

@Pckool

Copy link
Copy Markdown

Summary

Adds opt-in internal service URL overrides for LangSmith's core configuration and frontend reverse-proxy routes.

Why

The chart currently embeds Kubernetes service FQDNs in core environment variables and NGINX upstreams. This is normally correct, but deployments with custom DNS, service meshes, or alternate internal routing need to direct these calls elsewhere.

Changes

  • Add internalServiceUrls, an empty-by-default map of internal endpoint overrides.
  • Route core ConfigMap endpoints, frontend NGINX upstreams, agent-feature API routes, and the dependent agent-gateway/host-backend environment variables through shared helpers.
  • Preserve each existing Kubernetes service DNS URL when no override is supplied.
  • Document the values and add unit coverage for default and override behavior.

Validation

  • helm lint charts/langsmith -f charts/langsmith/ci/lightweight-config-values.yaml
  • helm unittest charts/langsmith (63 tests)
  • Rendered with custom URLs and confirmed no frontend proxy_pass retains a Kubernetes service FQDN.
  • Compared the default render with upstream main; outputs are byte-identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant