perf(l1): stride depth-gated trie commits every 32 layers - #7214
Open
NikhilSharmaWe wants to merge 3 commits into
Open
perf(l1): stride depth-gated trie commits every 32 layers#7214NikhilSharmaWe wants to merge 3 commits into
NikhilSharmaWe wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
external-contributor
NikhilSharmaWe
added a commit
to NikhilSharmaWe/ethrex
that referenced
this pull request
Aug 25, 2026
…lass#7214) Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
…lass#7214) Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
NikhilSharmaWe
force-pushed
the
perf/l1-depth-gated-commit-stride
branch
from
August 25, 2026 09:02
dd88b47 to
687ec93
Compare
Author
|
cc @edg-l |
# Conflicts: # crates/storage/lib.rs # crates/storage/store.rs
23 tasks
ilitteri
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commit_depth >= DB_COMMIT_THRESHOLD(no reorg overlay), depth-gated commits wait untildepth + DEPTH_GATED_COMMIT_STRIDE - 1parent-chain layers exist, then commit atdepth— amortizingrebuild_bloom, FKV Stop/Continue, and the trie write batch (~32× fewer commits on the warm retain-window path).commit_depth: None), batch depth (< 128), and overlay installs stay stride 1; journaling and per-blockflush_block_dataare unchanged.depth + 32; the retain window after each flush remains ~depth.Part of #7100 (item 2).
Test plan
cargo test -p ethrex-storage depth_gatedcargo test -p ethrex-storage get_commitable_by_depth_if_at_leastcargo test -p ethrex-test --features rocksdb bounded_reexec_without_fcu_bounds_memory_and_serves_window