Skip to content

add foundry support - #63

Open
0xnonso wants to merge 2 commits into
l2beat:masterfrom
0xnonso:master
Open

add foundry support#63
0xnonso wants to merge 2 commits into
l2beat:masterfrom
0xnonso:master

Conversation

@0xnonso

@0xnonso 0xnonso commented Oct 13, 2023

Copy link
Copy Markdown

Closes #60

@vercel

vercel Bot commented Oct 13, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
byor-wallet ✅ Ready (Inspect) Visit Preview Jan 21, 2024 4:32pm

mateuszradomski
mateuszradomski requested changes Oct 16, 2023
View reviewed changes

@mateuszradomski mateuszradomski left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Great start and I admire the courage to try and combine Hardhat and Foundry at the same time. But it's going to be easier to just drop Hardhat and support Foundry only. I've left some comments that coordinate this move plus that remove some unneeded files. Make sure to take a look at our CI, what it tests and how to make it pass. Also, please create a README.md in the contracts package to list all the possible things we would want to do and how to do them:

  • how to test
  • how to deploy
  • how to extend
  • how to build/typecheck

If you have any questions you're always welcome on our Discord (link is in the issue) :+]

Comment thread packages/contracts/.env.example Outdated
Comment thread packages/contracts/.github/workflows/test.yml Outdated
Comment thread packages/contracts/package.json Outdated
Comment thread packages/contracts/hardhat.config.ts Outdated
@0xnonso

0xnonso commented Oct 25, 2023

Copy link
Copy Markdown
Author

typescript check and linting wont be required, is it ok to remove and replace with just sol linting?

@mateuszradomski

mateuszradomski commented Oct 27, 2023

Copy link
Copy Markdown
Collaborator

typescript check and linting wont be required, is it ok to remove and replace with just sol linting?

yep, as long as the lint CI passes everything is fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mateuszradomski mateuszradomski mateuszradomski requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate the contracts package to Foundry

2 participants

@0xnonso @mateuszradomski