-
Notifications
You must be signed in to change notification settings - Fork 679
[DB-2037] Add EKUs phase 2: dual server certificates #5586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timothycoleman
wants to merge
15
commits into
master
Choose a base branch
from
timothycoleman/eku-phase2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fc77abd
remove (nearly) duplicate code that can now be referenced directly in…
timothycoleman c6bdaec
refactor out HasIpOrDnsSan helper
timothycoleman d54a758
add inbound certificate classifier
timothycoleman 85fa777
add options for client cluster certificate. when provided this certif…
timothycoleman 41cbb4f
remove SAN requirement from node certificate authentication (!)
timothycoleman 022a542
refactor: add helper method TryLoadCertificate
timothycoleman dcf0b96
refactor: add helper method LoadTrustedRootCertificates
timothycoleman 869f916
load and validate the cluster client certificate at startup
timothycoleman c2b77c0
use the cluster client certificate for outgoing connections to other …
timothycoleman d4ad49e
monitor both certificates for expiry
timothycoleman c09a7c8
rename from ClientClusterCertificate to NodeClientCertificate
timothycoleman 5923364
directory per test
timothycoleman cd6e62e
only check classification of node client cert on startup when part of…
timothycoleman cbbc6cf
add docs
timothycoleman 7118b5a
fix: track the trusted roots of the two certs separately. with a cert…
timothycoleman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -194,6 +194,98 @@ If multiple matching root certificates are found, then the root certificate with | |||||
| | YAML | `TrustedRootCertificateSubjectName` | | ||||||
| | Environment variable | `KURRENTDB_TRUSTED_ROOT_CERTIFICATE_SUBJECT_NAME` | | ||||||
|
|
||||||
| ### Node client certificate file | ||||||
|
|
||||||
| <Badge text="Experimental: Subject to change" type="warning" vertical="middle"/> | ||||||
|
|
||||||
| By default, a KurrentDB node uses the same certificate for both inbound connections (server authentication) and outbound connections to other nodes (client authentication). The node client certificate settings allow you to configure a separate certificate for outbound connections to other nodes. | ||||||
|
|
||||||
| This is useful when you want to use a certificate from a public CA for inbound client connections (which may only have the `serverAuth` EKU), while using a certificate from a private CA with both the `serverAuth` and `clientAuth` EKUs for inter-node communication. Using dual certificates this way is an alternative to enabling [`DisableClientAuthEkuValidation`](#disable-client-authentication-eku-validation) and keeps the node in compliance with RFC 5280. | ||||||
|
|
||||||
| If no node client certificate is configured, the node will use its main certificate as it's client certificate. | ||||||
|
||||||
| If no node client certificate is configured, the node will use its main certificate as it's client certificate. | |
| If no node client certificate is configured, the node will use its main certificate as its client certificate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 0 additions & 112 deletions
112
src/KurrentDB.Auth.UserCertificates.Tests/CertificateExtensionsTests.cs
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page says it's for KurrentDB v26.1, but the first release entry is labeled/linking to 26.0.1. Please align the heading/link (26.1.x) with the stated version, or adjust the page intro if it should still be 26.0.x.