configure.ac: Require gtk+-x11-3.0 via pkg-config - #12
Open
mgorny wants to merge 1 commit into
Open
Conversation
Change the required pkg-config module from gtk+-3.0 to gtk+-x11-3.0. Technically this does not change linked libraries but it ensures that GTK+ was built with X11 support. If GTK+ was built without X11 support (e.g. pure Wayland build), the package will fail at configure stage instead of failing to build with missing <gdk/gdkx.h> header.
Author
|
Ping. |
Author
|
Reping. |
|
Hey @mgorny, I'm not sure anyone will respond to that ping. The repo maintainers have long been dormant. It feels as if everyone has already switched to a more active fork, which I continue to be unaware of. |
Its just an extremely low maintenance library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the required pkg-config module from gtk+-3.0 to gtk+-x11-3.0.
Technically this does not change linked libraries but it ensures that
GTK+ was built with X11 support. If GTK+ was built without X11 support
(e.g. pure Wayland build), the package will fail at configure stage
instead of failing to build with missing <gdk/gdkx.h> header.