fix(cc): cache ordinary existing outputs - #772
Merged
Merged
Conversation
jleni
marked this pull request as ready for review
August 19, 2026 06:40
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h2to 0.4.16 after CI surfaced RUSTSEC-2026-0258Root cause
The output-path safety gate added in #664 treated every existing path as requiring compiler semantics. That protected special paths such as
/dev/null, but it also bypassed both cache reads and writes for normal CMake configuration rebuilds. Cache restore also only supported absent-path publication.Safety boundary
Only owner-writable, single-link regular files may be replaced. Restore validates the complete output set and revalidates each existing target immediately before replacement. Special outputs continue to receive the selected compiler's original path semantics unchanged.
Validation
cargo-mutants: 7/7 permission-admission mutants caughtFixes #744