Repository navigation
infra: commit the Terraform modules the docs reference, and tighten .gitignore - #5
Merged
Merged
Conversation
terraform/modules/frontend, terraform/modules/github-oidc-frontend and the whole frontend-infra-template/terraform tree existed only on my machine. The README and docs/frontend-deployment.md both point at them, so anyone following the deployment guide hit missing modules — the documented path could not be walked from a clean clone. Adds a backend.tf.example note explaining that the real backend.tf is gitignored: the state bucket name is account-specific, and frontend-infra-template already used the .example convention. Also extends .gitignore for things that were untracked but not ignored, so a stray `git add -A` could commit them — as very nearly happened while working on the security change: - videos/ (ensantina.mp4 is ~33MB; git is the wrong place for it) - thumb.jpg, results/ — generated at runtime - refactorPlan.md, terraformPlan.md — local planning scratch, same category as the working notes removed from docs/ earlier - terraform/**/backend.tf, keeping the .example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing infrastructure
terraform/modules/frontend,terraform/modules/github-oidc-frontendand theentire
frontend-infra-template/terraformtree existed only on my machine. TheREADME and
docs/frontend-deployment.mdboth point at them, so anyone followingthe deployment guide from a clean clone hit missing modules — the documented path
could not actually be walked.
Scanned before committing: no credentials, no state files, no tfvars. The only
matches for secret-like patterns were the standard GitHub OIDC issuer URL
(
token.actions.githubusercontent.com).backend.tfstays gitignored with an explanatory.example— the state bucketname is account-specific, and
frontend-infra-templatealready used thatconvention.
.gitignore
These were untracked but not ignored, so a stray
git add -Awould committhem — which very nearly happened while working on the security change:
videos/—ensantina.mp4is ~33 MBthumb.jpg,results/— generated at runtimerefactorPlan.md,terraformPlan.md— local planning scratch, the samecategory as the working notes removed from
docs/earlierterraform/**/backend.tf, keepingbackend.tf.exampleNo application code changes.