Skip to content

infra: commit the Terraform modules the docs reference, and tighten .gitignore - #5

Merged
konradkelly merged 1 commit into
mainfrom
infra/commit-missing-terraform
Aug 13, 2026
Merged

konradkelly merged 1 commit into
mainfrom
infra/commit-missing-terraform

Conversation

@konradkelly

Copy link
Copy Markdown
Owner

Missing infrastructure

terraform/modules/frontend, terraform/modules/github-oidc-frontend and the
entire frontend-infra-template/terraform tree existed only on my machine. The
README and docs/frontend-deployment.md both point at them, so anyone following
the deployment guide from a clean clone hit missing modules — the documented path
could not actually be walked.

Scanned before committing: no credentials, no state files, no tfvars. The only
matches for secret-like patterns were the standard GitHub OIDC issuer URL
(token.actions.githubusercontent.com).

backend.tf stays gitignored with an explanatory .example — the state bucket
name is account-specific, and frontend-infra-template already used that
convention.

.gitignore

These were untracked but not ignored, so a stray git add -A would commit
them — which very nearly happened while working on the security change:

  • videos/ — ensantina.mp4 is ~33 MB
  • thumb.jpg, results/ — generated at runtime
  • refactorPlan.md, terraformPlan.md — local planning scratch, the same
    category as the working notes removed from docs/ earlier
  • terraform/**/backend.tf, keeping backend.tf.example

No application code changes.

terraform/modules/frontend, terraform/modules/github-oidc-frontend and the whole
frontend-infra-template/terraform tree existed only on my machine. The README and
docs/frontend-deployment.md both point at them, so anyone following the
deployment guide hit missing modules — the documented path could not be walked
from a clean clone.

Adds a backend.tf.example note explaining that the real backend.tf is gitignored:
the state bucket name is account-specific, and frontend-infra-template already
used the .example convention.

Also extends .gitignore for things that were untracked but not ignored, so a
stray `git add -A` could commit them — as very nearly happened while working on
the security change:

- videos/ (ensantina.mp4 is ~33MB; git is the wrong place for it)
- thumb.jpg, results/ — generated at runtime
- refactorPlan.md, terraformPlan.md — local planning scratch, same category as
  the working notes removed from docs/ earlier
- terraform/**/backend.tf, keeping the .example
@konradkelly
konradkelly merged commit 7f51129 into main Aug 13, 2026
2 checks passed
@konradkelly
konradkelly deleted the infra/commit-missing-terraform branch August 13, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant