Release 2.2.10 (build 50) - #211
Merged
Merged
Conversation
Applied by the Flutter tooling on build. AppDelegate registers plugins from didInitializeImplicitFlutterEngine instead of didFinishLaunchingWithOptions, which requires the matching UIApplicationSceneManifest naming FlutterSceneDelegate — the two only work as a pair. These files were already in the tree when 2.2.10 build 50 was archived, so committing them is what makes that binary reproducible.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR updates Flutter engine initialization, iOS application metadata, Xcode debugging settings, and release version values. It also removes ChangesiOS Flutter integration and release update
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant FlutterEngine
participant AppDelegate
participant PluginRegistry
FlutterEngine->>AppDelegate: didInitializeImplicitFlutterEngine
AppDelegate->>PluginRegistry: register plugins
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts 2.2.10 build 50, carrying #209 and #210.
Version
pubspec.yamlplusMARKETING_VERSIONandCURRENT_PROJECT_VERSIONinproject.pbxproj(three occurrences each) —Info.plistreads both from the pbxproj variables, so bumping pubspec alone is silently ignored.Build number jumps 48 → 50: a 49 was uploaded without the bump being committed, so 49 is taken on App Store Connect.
iOS lifecycle migration
AppDelegatenow registers plugins fromdidInitializeImplicitFlutterEnginerather thandidFinishLaunchingWithOptions, paired with aUIApplicationSceneManifestnamingFlutterSceneDelegate. The Flutter tooling applied these on build; they only work as a pair. Also dropsMinimumOSVersionfromAppFrameworkInfo.plistand adds the LLDB init file to the scheme.These were already in the working tree when build 50 was archived, so committing them is what makes that binary reproducible from the repo.
Not verified at runtime. The archive builds and the Dart suite passes, but plugin registration is a launch-time path — a broken migration produces an app that starts with no plugins registered. Install the build on a device and confirm login and playback before shipping this to the App Store.
Checks
459 tests passing locally. No CI — GitHub Actions was down when this went up; worth a re-run once it recovers.
Summary by CodeRabbit