Repository navigation
Conversation
- Remove NamedPipeService (incl. NamedPipeCommand/CommandType), HintOverlayClient, and the client examples; none were registered or reachable in the shipped build (external control surface decision #33) - Drop the commented-out pipe wiring and the pipe-only OnNamedPipeCommandReceived/SelectHintByLabel handlers in HintController - Remove orphaned xunit package references from the app project and the CI step that scrubbed xunit.* from Debug output (testing decision #36) - Correct the phase doc: NamedPipeCommand/CommandType lived in NamedPipeService.cs, not Models.cs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executes Phase 00 of the architecture modernization spec.
Changes
NamedPipeService.cs(including theNamedPipeCommand/CommandTypetypes declared in it),NamedPipeClient/HintOverlayClient.cs,Examples/HintOverlayClientExamples.cs, the commented-out DI registration and controller wiring, and the pipe-onlyOnNamedPipeCommandReceived/SelectHintByLabelhandlers (the latter had no other callers). The README''s keystroke-based Talon integration is untouched.xunit.assert/xunit.v3.extensibility.corepackage references in the app csproj (no xunit usage exists in the project) and the CI "Clean Debug output" step that scrubbedxunit.*from the Debug artifact.NamedPipeCommand/CommandTypelived inModels.cs; they were declared at the bottom ofNamedPipeService.cs.Definition of done
xunit.*filesNamedPipe/HintOverlayClient/CommandTypereferences remain outside the spec docsNo behavior change.
🤖 Generated with Claude Code