Skip to content

Phase 00: Dead code deletion and test hygiene - #43

Open
knausj85 wants to merge 1 commit into
modernizefrom
phase/00-dead-code
Open

knausj85 wants to merge 1 commit into
modernizefrom
phase/00-dead-code

Conversation

@knausj85

@knausj85 knausj85 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Executes Phase 00 of the architecture modernization spec.

Changes

  • Named-pipe surface deleted (per external control surface decision #33): NamedPipeService.cs (including the NamedPipeCommand/CommandType types declared in it), NamedPipeClient/HintOverlayClient.cs, Examples/HintOverlayClientExamples.cs, the commented-out DI registration and controller wiring, and the pipe-only OnNamedPipeCommandReceived/SelectHintByLabel handlers (the latter had no other callers). The README''s keystroke-based Talon integration is untouched.
  • Orphaned test references removed (per testing decision #36): xunit.assert/xunit.v3.extensibility.core package references in the app csproj (no xunit usage exists in the project) and the CI "Clean Debug output" step that scrubbed xunit.* from the Debug artifact.
  • Spec correction: the phase doc claimed NamedPipeCommand/CommandType lived in Models.cs; they were declared at the bottom of NamedPipeService.cs.

Definition of done

  • Solution builds (Debug, full MSBuild path) with no references to the deleted types — verified locally; Debug output contains no xunit.* files
  • Straggler sweep: no NamedPipe/HintOverlayClient/CommandType references remain outside the spec docs
  • CI green (lint + Debug + Release jobs)
  • Manual smoke test sections 1, 4, 6 (hint workflow, taskbar mode, tray/lifecycle)

No behavior change.

🤖 Generated with Claude Code

- Remove NamedPipeService (incl. NamedPipeCommand/CommandType),
  HintOverlayClient, and the client examples; none were registered or
  reachable in the shipped build (external control surface decision #33)
- Drop the commented-out pipe wiring and the pipe-only
  OnNamedPipeCommandReceived/SelectHintByLabel handlers in HintController
- Remove orphaned xunit package references from the app project and the
  CI step that scrubbed xunit.* from Debug output (testing decision #36)
- Correct the phase doc: NamedPipeCommand/CommandType lived in
  NamedPipeService.cs, not Models.cs

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant