Repository navigation
feat(engine): migrate to Rust Edition 2024 and latest stable toolchain - #2
Merged
Merged
Conversation
- Bump edition to 2024 and MSRV to 1.88.0 in Cargo.toml - Add rust-toolchain.toml pinning stable channel with rustfmt and clippy - Modernize nested if-let expressions to idiomatic 2024 let-chains - Apply Style Edition 2024 formatting across all modules - Bump dependencies to latest compatible versions in Cargo.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
kkpdf-zedto the latest Rust Edition 2024 with full MSRV alignment, idiomatic let-chains, and Style Edition 2024 formatting.Key Changes
edition = "2024"andrust-version = "1.88.0"inCargo.toml.rust-toolchain.tomlconfigured forchannel = "stable"withrustfmtandclippy.if letblocks into idiomatic 2024 let-chains (if let Some(...) = ... && let Some(...) = ...), resolving-D clippy::collapsible_if.cargo fmtunder Rust Style Edition 2024 across the repository.Cargo.lockpatch updates forcc,errno, andlibloading.Verification
cargo fmt --check: Clean (0 diffs).cargo clippy --all-targets -- -D warnings: Clean (0 warnings).cargo test --all-targets: All 34 tests (unit and integration) passed cleanly.cargo run --example viewer: Successfully executed standalone benchmark runner and verified sample image outputs.check_no_secrets.py: Clean (0 credentials).