Skip to content

Simplify analysis and tool reporting - #213

Closed
kjanat wants to merge 6 commits into
jiggamariggamafrom
stack/review-cleanup
Closed

kjanat wants to merge 6 commits into
jiggamariggamafrom
stack/review-cleanup

Conversation

@kjanat

@kjanat kjanat commented Oct 2, 2026

Copy link
Copy Markdown
Owner

Render Action output directly from typed analysis and count canonical diagnostics. Preserve existing text formatting, snippets, escaping and ranges.

  • Group executable-bit state and name composite fork/join transitions, preserving conditional checkout and mode-change behavior.
  • Move analyzer-specific composite handling out of the generic visitor. Stop traversal when analysis is cancelled.
  • Debug output explains each ShellCheck invocation: dialect origin, directory, rc/inline settings, arguments and source-following fallback.
  • Probe PATH-selected ShellCheck/Pyflakes versions with a one-second deadline. Unsupported probes remain advisory; PATH precedence stays intact.

Validation: executable/composite regressions, focused cancellation/context tests, native Action renderer tests, tool tests/typecheck, and the built JavaScript entrypoint smoke test passed locally. POSIX-only probe cases await CI.

Seventh stack layer, based on #204. Release rehearsal is separate; this adds no traversal cap.

kjanat added 5 commits October 2, 2026 13:27
Render native Action results directly from typed diagnostics.
Group executable state transitions and composite traversal ownership;
stop nested analysis promptly when its context is cancelled.

Report resolved ShellCheck invocation context and probe PATH tool
versions without changing tool selection. Refresh generated metadata.

Validate focused Go analysis and native Action tests, tool tests,
type checks, and the built JavaScript Action entrypoint.
@kjanat kjanat added type:maintenance Upkeep: dependencies, tooling, documentation, and refactors dx Developer experience, for contributors and for people running the CLI area:github-action GitHub Action packaging, inputs, outputs, and runtime behavior area:rules Lint rules, policy checks, and their diagnostics labels Oct 2, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T12:29:11.748548Z 37109ed PR opened
🔒 Security Review ✅ Completed 2026-10-02T12:30:32.348057Z 37109ed PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@autofix-ci

autofix-ci Bot commented Oct 2, 2026

Copy link
Copy Markdown

Applied automated formatting and modernization fixes. Please review the generated commit.

@kjanat
kjanat added this pull request to stack #188 October 2, 2026 12:32
@kjanat

kjanat commented Oct 2, 2026

Copy link
Copy Markdown
Owner Author

Move changes into their owning layers.
This is a disgrace to the concept of stacking!

@kjanat kjanat closed this Oct 2, 2026
@kjanat
kjanat removed this pull request from stack #188 October 2, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:github-action GitHub Action packaging, inputs, outputs, and runtime behavior area:rules Lint rules, policy checks, and their diagnostics dx Developer experience, for contributors and for people running the CLI type:maintenance Upkeep: dependencies, tooling, documentation, and refactors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant