Skip to content

fix: require --compactFile in CKF, GNN, and geometry-visualization options - #97

Open
jbeirer wants to merge 1 commit into
key4hep:mainfrom
jbeirer:main-FixRequireFlag
Open

fix: require --compactFile in CKF, GNN, and geometry-visualization options#97
jbeirer wants to merge 1 commit into
key4hep:mainfrom
jbeirer:main-FixRequireFlag

Conversation

@jbeirer

@jbeirer jbeirer commented Sep 10, 2026

Copy link
Copy Markdown
Member

BEGINRELEASENOTES

  • Fixed a cryptic Gaudi TypeError/ValueError when --compactFile was omitted in CLD_CKFTracking.py, runGNNTrackFinding.py, and test_visualize_acts_geo.py by making the argument required, with a clear error message.

ENDRELEASENOTES

Summary

--compactFile was optional in several options scripts. When omitted, the resulting None reached GeoSvc's detectors property as [None], which failed deep in Gaudi's PropertyProxy._isCompatible with a cryptic TypeError: NoneType takes no arguments / ValueError: received an instance of <class 'NoneType'>, but <class 'NoneType'> expected for property detectors.

Marking --compactFile required=True in the three affected scripts fails fast with a readable argparse error instead.

@tmadlener

Copy link
Copy Markdown
Member

pre-commit failures are pre-existing, see #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants