fix: require --compactFile in CKF, GNN, and geometry-visualization options - #97
Open
jbeirer wants to merge 1 commit into
Open
fix: require --compactFile in CKF, GNN, and geometry-visualization options#97jbeirer wants to merge 1 commit into
jbeirer wants to merge 1 commit into
Conversation
Member
|
pre-commit failures are pre-existing, see #96 |
tmadlener
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
TypeError/ValueErrorwhen--compactFilewas omitted inCLD_CKFTracking.py,runGNNTrackFinding.py, andtest_visualize_acts_geo.pyby making the argument required, with a clear error message.ENDRELEASENOTES
Summary
--compactFilewas optional in several options scripts. When omitted, the resultingNonereachedGeoSvc'sdetectorsproperty as[None], which failed deep in Gaudi'sPropertyProxy._isCompatiblewith a crypticTypeError: NoneType takes no arguments/ValueError: received an instance of <class 'NoneType'>, but <class 'NoneType'> expected for property detectors.Marking
--compactFilerequired=Truein the three affected scripts fails fast with a readable argparse error instead.