Conversation
Most of the Acts downstream assumes a shared_ptr, so we might as well return one from here
Make the ActsGeoSvc implementation return a constant magnetic field along for now.
We're only using this in legacy mode. We have the permanent desire to get back to improving our gaudi support since all our algorithms are written in a framework-agnostic and this is exercised through a gaudi pipeline, but it's obviously a lower priority. As long as there's a release before major changes take effect, we can pin on that. It may be there already... Or we can pin on a commit too. |
|
Sounds good. We have https://github.com/key4hep/k4ActsTracking/releases/tag/v00-01 from end of October. No behavior changing changes have landed since, so IIUC we could break things for the next tag, right? |
Break all you want :-) |
|
|
||
| class GAUDI_API IActsGeoSvc : virtual public IService { | ||
| public: | ||
| using VolumeSurfaceMap = std::unordered_map<uint64_t, const Acts::Surface*>; |
There was a problem hiding this comment.
| using CellIDSurfaceMap = std::unordered_map<uint64_t, const Acts::Surface*>; |
BEGINRELEASENOTES
IActsGeoSvcreturn the tracking geometry as ashared_ptrto better align with downstream usagemagneticFieldmethod to theIActsGeoSvcand return a constant B field for now.ENDRELEASENOTES
@wdconinc Do I remember correctly that you are still using this and this will probably be breaking changes?