Skip to content

Preserve source timezone in chart timestamps #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Whning0513 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Preserve source timezone in chart timestamps #1381

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1809e75
Preserve source timezone in chart timestamps
Whning0513 Jul 29, 2026
70ab81f
Normalize trade timestamps for Bokeh
Whning0513 Jul 29, 2026
bfe44f1
Format timezone helper separation
Whning0513 Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions backtesting/_plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,14 @@ def _windos_safe_filename(filename):
return filename


def _remove_timezone(values):
if isinstance(values, pd.DatetimeIndex):
return values.tz_localize(None) if values.tz is not None else values
if isinstance(values, pd.Series) and isinstance(values.dtype, pd.DatetimeTZDtype):
return values.dt.tz_localize(None)
return values


def _bokeh_reset(filename=None):
curstate().reset()
if filename:
Expand Down Expand Up @@ -239,7 +247,7 @@ def plot(*, results: pd.Series,
resample, df, indicators, equity_data, trades)

df.index.name = None # Provides source name @index
df['datetime'] = df.index # Save original, maybe datetime index
df['datetime'] = _remove_timezone(df.index) # Save original, maybe datetime index
df = df.reset_index(drop=True)
equity_data = equity_data.reset_index(drop=True)
index = df.index
Expand Down Expand Up @@ -268,7 +276,7 @@ def plot(*, results: pd.Series,

trade_source = ColumnDataSource(dict(
index=trades['ExitBar'],
datetime=trades['ExitTime'],
datetime=_remove_timezone(trades['ExitTime']),
size=trades['Size'],
returns_positive=(trades['ReturnPct'] > 0).astype(int).astype(str),
))
Expand Down