Added additional screen reader accessibility support to conform with the ARIA APG 1.1 Carousel Design pattern as recently changed with the W3C, plus fixed the breaking of keyboard and screen reader accessibility every time autoplay is set to true. - #3773
Open
accdc wants to merge 10 commits into
Conversation
…ole=tabpanel properly accessible
…ons during screen reader navigation.
…ould not be an option, it should just be keyboard accessible always.
…or plug and play within current implementations.
…yboard support is enabled.
…enable autoplay if true in combo with accessibility and keyboard accessibility events.
…bel when using the arrow keys to navigate.
…ouncement for screen reader users.
Collaborator
|
I am by no mean an expert on that so I will take your words for it. This is what you’re referring to? If we no longer need this part: I would suggest we completely remove it instead of commenting it out. I would definitely love to see this integrated in 1.9.1 |
Morkowski
approved these changes
Aug 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.