Add support for PRF extension with passkeys - #13529
Open
varjolintu wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for PRF extension with the passkeys feature. It allows creating and using passkeys with sites that will not work without the PRF support.
The implementation supports three different ways to handle the PRF salt:
evalByCredentialto provide a credential ID that must be checked against theallowCredentialslist. When the ID's match, the PRF response is built using that salt.Retrieving a passkey had to be refactored to handle extensions after a credential has been selected in KeePassXC. The previously stored PRF secret must be retrieved for handling the PRF extension response.
Related browser side PR: keepassxreboot/keepassxc-browser#3048
References / specs:
https://www.w3.org/TR/webauthn-3/#prf-extension
https://developers.yubico.com/WebAuthn/Concepts/PRF_Extension/Developers_Guide_to_PRF.html
https://botan.randombit.net/handbook/api_ref/kdf.html
https://github.com/w3c/webauthn/blob/main/explainers/prf-extension.md
Testing strategy
Useful sites for testing:
https://www.passkeyprf.com
https://webauthn-passkeys-prf-demo.explore.corbado.com
Real sites for testing:
https://posteo.de/en
https://confer.to
https://vault.bitwarden.com/#/login
Automatic tests added.
Type of change