Skip to content

Fix tag dropdown not finalizing selection #13490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abdosaeedelhassan wants to merge 1 commit into
base: develop
Choose a base branch
from
+13 −1
Open

Fix tag dropdown not finalizing selection #13490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/gui/PasswordWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,11 @@ void PasswordWidget::checkCapslockState()
}
}

void PasswordWidget::setPasswordStrength(const QString& password)
{
updatePasswordStrength(password);
}

Comment on lines +265 to +269

@droidmonkey droidmonkey Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of this change

void PasswordWidget::updatePasswordStrength(const QString& password)
{
if (password.isEmpty()) {
Expand Down
1 change: 1 addition & 0 deletions src/gui/PasswordWidget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ public slots:
void selectAll();
void setReadOnly(bool state);
void setEchoMode(QLineEdit::EchoMode mode);
void setPasswordStrength(const QString& password);

@droidmonkey droidmonkey Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

void setClearButtonEnabled(bool enabled);

private slots:
Expand Down
3 changes: 3 additions & 0 deletions src/gui/entry/EditEntryWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1024,6 +1024,9 @@ void EditEntryWidget::setForms(Entry* entry, bool restore)
m_mainUi->usernameComboBox->lineEdit()->setText(entry->username());
m_mainUi->urlEdit->setText(entry->url());
m_mainUi->passwordEdit->setText(entry->password());
if (entry->isAttributeReference("Password")) {
m_mainUi->passwordEdit->setPasswordStrength(entry->resolveMultiplePlaceholders(entry->password()));
}
Comment on lines +1027 to +1029

@droidmonkey droidmonkey Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

m_mainUi->passwordEdit->setShowPassword(!config()->get(Config::Security_PasswordsHidden).toBool());
if (!m_history) {
m_mainUi->passwordEdit->enablePasswordGenerator();
Expand Down
5 changes: 4 additions & 1 deletion src/gui/tag/TagsEdit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,10 @@ struct TagsEdit::Impl
completer->setCaseSensitivity(Qt::CaseInsensitive);
connect(completer.get(),
static_cast<void (QCompleter::*)(QString const&)>(&QCompleter::activated),
[this](QString const& text) { currentText(text); });
[this](QString const& text) {
currentText(text);
editNewTag(editing_index + 1);
});
}

QVector<QTextLayout::FormatRange> formatting() const
Expand Down