fixed dead keys in master password input - #13412
Open
ArnoldSmith86 wants to merge 1 commit into
Open
Conversation
Member
|
So this basically unhides the input automatically? That is not acceptable. IIRC this bug is related to Qt itself. |
Author
No, it stays hidden (at least for me, visually). I do see the backtick though while it is waiting for the second keystroke. |
Member
|
Screenshots would be nice to assist immediate review. My understanding is that the IMH for hiden text is rather fundamental to a password field and removing it generally defeats the purpose of having a password field. I would much rather add a warning when setting a master password to avoid using dead keys because of this issue. |
Author
Member
|
I will check out the true risk with not having hiddennText set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

My master key contains a backtick. When showing the password in plain text while entering, I can enter it with the dead key on my German keyboard just fine. But if the input is hidden, the dead key doesn't work and the backtick is simply ommited. I'm using Linux Mint.
I asked Claude to fix it and this PR is what it came up with and it seems to work fine. Looking at the code, the position seems questionable and it might very well not be a desired change if it messes with security. In that case, just close the PR.
Here's the comment that Claude added alongside the code:
Testing strategy
I tested my password containing a backtick with a German keyboard on the current
developbranch and with the fix.Type of change