fix: consecutive leading **/ should match like a single **/ - #161
Merged
kaelzhang merged 1 commit intoJul 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pattern with consecutive leading globstars such as
**/**/foofails to matchfooat the repository root, whilegit check-ignorematches it.Only the root case is wrong;
a/fooanda/b/fooalready match. Git treats a run of leading**/the same as a single**/("match in all directories", including zero), so**/**/foois equivalent to**/foo.Cause: the leading-globstar replacer only consumes the first
**/. The remaining**/is then handled as an ordinary**, which forces at least one intermediate directory and drops the root match.Fix: let the replacer consume one or more consecutive leading
**/runs.**/**/foonow compiles to the same regex as**/foo.Adds a regression test to
test/fixtures/cases.js(exercised by.ignores(),.filter(),.checkIgnore()and thegit check-ignorefixture oracle).