Repository navigation
fix(portainer): declare telemetry and pin image versions in the template - #163
Merged
Merged
Conversation
The template now says what the anonymous telemetry sends and offers a field to turn it off, and the compose passes MAINTENANT_DISABLE_TELEMETRY and MAINTENANT_ALLOWED_HOSTS through. The images are pinned so the stack deploys a released version, and the description no longer claims Swarm and Kubernetes for a stack that only watches the Docker host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Portainer catalog review found that the template did not mention the anonymous telemetry, and that a variable added to the stack in Portainer never reached the container, since the compose lists its environment explicitly.
MAINTENANT_DISABLE_TELEMETRYandMAINTENANT_ALLOWED_HOSTSthrough.ghcr.io/kolapsis/maintenant:1.11.0andtecnativa/docker-socket-proxy:v0.5.0, so the stack deploys a released version. The release bump updates the maintenant tag with the other version strings.