Fix missing return and variable shadowing in RemoteMachine controller - #1369
Open
kahirokunn wants to merge 2 commits into
Open
Fix missing return and variable shadowing in RemoteMachine controller#1369kahirokunn wants to merge 2 commits into
kahirokunn wants to merge 2 commits into
Conversation
kahirokunn
changed the title
kahirokunn
force-pushed
the
fix/remote-machine-controller-bugs
branch
2 times, most recently
from
February 25, 2026 05:26
62d67b0 to
e68ff3d
Compare
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kahirokunn
force-pushed
the
fix/remote-machine-controller-bugs
branch
from
February 25, 2026 05:27
e68ff3d to
0f78267
Compare
|
The PR is marked as stale since no activity has been recorded in 30 days |
|
The PR is marked as stale since no activity has been recorded in 30 days |
|
The PR is marked as stale since no activity has been recorded in 30 days |
|
The PR is marked as stale since no activity has been recorded in 30 days |
|
This pull request has merge conflicts that need to be resolved. |
|
The PR is marked as stale since no activity has been recorded in 30 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RemoteMachine controller has several issues: