fix: make multi-architecture builds reliable - #6
Merged
Conversation
Signed-off-by: jwcesign <jiangwei@cloudpilot.ai>
|
Thanks to your contribution, the maintainers will review it as soon as they can! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Multi-platform builds downloaded dependencies separately for each architecture through a flaky proxy. A truncated wheel download caused
pip installto fail immediately, and source changes invalidated the dependency layer because application files were copied first. The image also upgraded pip to an unpinned latest version on every build.Proposed Changes
requirements.txtbefore application source so dependency layers remain reusable..dockerignoreso only runtime source enters the build context.Validation
linux/amd64,linux/arm64Buildx build passed withmultiarch-proxy.python -m unittest discover -s tests(6 tests)git diff --checkRelease Note