Skip to content

_check_host_allowlist: only allow valid hostname chars - #637

Draft
manics wants to merge 1 commit into
jupyterhub:mainfrom
manics:validate-proxy-remote-host
Draft

manics wants to merge 1 commit into
jupyterhub:mainfrom
manics:validate-proxy-remote-host

Conversation

@manics

@manics manics commented Nov 6, 2026

Copy link
Copy Markdown
Member

Checklist

  • I am the author of this work

What does this PR do?

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Maintenance (testing, packaging, infrastructure, metadata)
  • Other

Is this PR related to an issue, or is it part of a larger body of work?

Does this PR introduce a breaking change?

How can this PR be tested?

Set a callable host_allowlist that allows everything. Check it doesn't allow hostnames with invalid characters that are %encoded

What should a reviewer concentrate their feedback on?

Other information

@manics manics added the bug label Nov 6, 2026
@manics manics mentioned this pull request Nov 6, 2026
2 of 11 tasks
@manics
manics marked this pull request as draft November 7, 2026 13:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant