Skip to content

Introduce policy for new images/packages - #2016

Merged
mathbunnyru merged 4 commits into
jupyter:mainfrom
mathbunnyru:images_policy
Oct 27, 2023
Merged

Introduce policy for new images/packages#2016
mathbunnyru merged 4 commits into
jupyter:mainfrom
mathbunnyru:images_policy

Conversation

@mathbunnyru

@mathbunnyru mathbunnyru commented Oct 24, 2023

Copy link
Copy Markdown
Member

Describe your changes

I'm combing @consideRatio and @minrk ideas from #1958 and my proposal of voting from #2000.

Issue ticket if applicable

Fix: #1958

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

Comment on lines +28 to +35
With all this in mind, we have a voting group, which consists of
[mathbunnyru](http://github.com/mathbunnyru),
[consideRatio](http://github.com/consideRatio),
[yuvipanda](https://github.com/yuvipanda) and
[minrk](https://github.com/minrk).

This voting group is responsible for accepting or declining new packages and stacks.
The change is accepted, if there are **at least 2 positive votes**.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@consideRatio @yuvipanda @minrk how do you feel about this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the simplicity of this!

@consideRatio consideRatio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great starting point, and I don't come up with suggested changed to work before merge. I think this should be approved by more people than me though!

@yuvipanda

Copy link
Copy Markdown
Contributor

Honored to be a part of this, and looks good to me as a great start. I would also nominate @manics to be a part of this group if you feel ok with it, given he does a lot of work on repo2docker as well.

@minrk

minrk commented Oct 26, 2023

Copy link
Copy Markdown
Member

I think the principle makes good sense. I don't feel like I'm contributing much here, so I think I'd prefer not to be on the voting list.

@mathbunnyru

Copy link
Copy Markdown
Member Author

Honored to be a part of this, and looks good to me as a great start. I would also nominate @manics to be a part of this group if you feel ok with it, given he does a lot of work on repo2docker as well.

Thanks for the suggestion! @manics I added you to the list. Please, tell me if you feel comfortable with this.

@mathbunnyru

Copy link
Copy Markdown
Member Author

I think the principle makes good sense. I don't feel like I'm contributing much here, so I think I'd prefer not to be on the voting list.

Ok, I removed you from the list. If you ever change your mind, please, let me know 🙂

@manics

manics commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

Thanks for the suggestion! @manics I added you to the list. Please, tell me if you feel comfortable with this.

Yes, I'm happy to help, thanks for asking!

@mathbunnyru
mathbunnyru merged commit 2e35c52 into jupyter:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Policy on adding new images

5 participants