Skip to content

fix: review the whole branch, not just the uncommitted files - #7

Merged
jsellam merged 1 commit into
masterfrom
fix-file-list
Sep 8, 2026
Merged

jsellam merged 1 commit into
masterfrom
fix-file-list

Conversation

@jsellam

@jsellam jsellam commented Sep 8, 2026

Copy link
Copy Markdown
Owner

auto tested the working tree for dirtiness first and short-circuited to HEAD, so a single uncommitted file collapsed the range and hid every commit the branch had made since leaving the default branch.

It now takes the merge base with the default branch whenever HEAD is ahead of it, dirty or not — a branch is reviewed as a unit, the way a pull request is. HEAD remains the base only when there is nothing wider to show: no default branch, HEAD already on it, or histories with no common ancestor (which used to throw a GitError once the tree was clean).

`auto` tested the working tree for dirtiness first and short-circuited to
`HEAD`, so a single uncommitted file collapsed the range and hid every
commit the branch had made since leaving the default branch.

It now takes the merge base with the default branch whenever HEAD is ahead
of it, dirty or not — a branch is reviewed as a unit, the way a pull request
is. `HEAD` remains the base only when there is nothing wider to show: no
default branch, HEAD already on it, or histories with no common ancestor
(which used to throw a GitError once the tree was clean).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@jsellam
jsellam merged commit ebacbfb into master Sep 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant