node(svm): add incomplete log replay coverage - #12
Open
ayushmishra2005 wants to merge 1 commit into
Open
Conversation
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a focused Solana watcher replay case on top of wormhole-foundation#4924 for incomplete transaction logs.
The new fixture keeps the transaction/account data valid but preserves only the core program invoke log and omits the
Sequenceline. This covers the current behavior across the replay paths:The three successful paths produce the same VAA signing digest.
This also includes the minimum testgen compatibility update needed for the current wormhole-foundation#4924 head.
MessagePublicationAccountnow usesVaaTimeandVaaSignatureAccountinstead of the removed fields. The stalepm_reliable_not_finalizedscenario was removed because it depended on the removedMessageStatusfield.Validation:
go test ./pkg/watchers/solana/testgen/...go run ./pkg/watchers/solana/testgen/cmd staticUPDATE_SOLANA_REPLAY_FIXTURES=1 go test -v ./pkg/watchers/solana/ -run TestReplayGeneratedBundlesgo test ./pkg/watchers/solana/ -run TestReplayGeneratedBundlesgo test ./pkg/watchers/solana/...git diff --checkAll pass.
@djb15 this is the test-only follow-up you suggested around wormhole-foundation#4924.