fix(hydraulics): fix SumBetweenDepths layer integration logic and add pFUnit test - #1
Closed
johnpaulalex wants to merge 1 commit into
Closed
Conversation
johnpaulalex
force-pushed
the
fix/sum-btwn-depths+hydr-plant
branch
from
August 7, 2026 18:44
9be779b to
6cc2a4c
Compare
johnpaulalex
force-pushed
the
test/hydr-plant+hydr-base
branch
from
August 7, 2026 18:54
ff6d4ad to
3c185fb
Compare
johnpaulalex
force-pushed
the
fix/sum-btwn-depths+hydr-plant
branch
3 times, most recently
from
August 7, 2026 19:56
882a63e to
33b1222
Compare
johnpaulalex
force-pushed
the
test/hydr-plant+hydr-base
branch
from
August 7, 2026 19:58
6a89caa to
eeaf06d
Compare
johnpaulalex
force-pushed
the
fix/sum-btwn-depths+hydr-plant
branch
from
August 7, 2026 19:59
33b1222 to
de02de9
Compare
… pFUnit test Corrects partial-layer depth integration calculations in SumBetweenDepths when top and bottom integration depths fall within a single soil layer or at the topmost layer boundary (i_rhiz_b == 0). Adds test_SumBetweenDepths to FatesPlantHydraulicsMod_geom_test.pf.
johnpaulalex
force-pushed
the
fix/sum-btwn-depths+hydr-plant
branch
from
August 7, 2026 20:00
de02de9 to
de7afd1
Compare
Owner
Author
|
Closing draft PR on fork; moved to draft PR on main repository: NGEET#1603 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes partial-layer depth integration calculations in
SumBetweenDepthswithinbiogeophys/FatesPlantHydraulicsMod.F90. Specifically:depth_t) and bottom depth (depth_b) fall within the exact same soil rhizosphere layer (i_rhiz_t - 1 == i_rhiz_b + 1). Previously, partial layer fractions were miscalculated or double-counted across layer boundaries.i_rhiz_b == 0when integrating from the surface down through the top layer (frac = depth_b / dz_rhiz(1)).SumBetweenDepthsfor unit testing and adds comprehensive test coverage (test_SumBetweenDepthsinFatesPlantHydraulicsMod_geom_test.pf) verifying integration density across non-uniform soil layer interfaces, partial overlaps, and out-of-bound depth limits.Specific notes
Contributors other than yourself, if any:
Linked issues addressed, if any:
Description of generative AI usage:
Answer Changes & Scientific Impact
i_rhiz_b == 0). Simulations without plant hydraulics remain Bit-for-Bit (B4B).User Interface & Namelist Changes
testing/CMakeLists.txtandtesting/config/unit.cfgto registerfates_plant_hydraulics_test.Testing planned or performed, if any:
FatesPlantHydraulicsMod:FatesPlantHydraulicsMod_cohort_testFatesPlantHydraulicsMod_drive_testFatesPlantHydraulicsMod_geom_testFatesPlantHydraulicsMod_sizedep_testFATES baseline hash-tag:
5efa6fbfPR branch hash-tag:
de7afd15Requirements before merge: