Skip to content

fix: Fixes parsing translation params. #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damencho merged 1 commit into from
Jun 17, 2026
Merged

fix: Fixes parsing translation params. #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/org/jitsi/jigasi/transcription/BingTranslationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
import org.jitsi.utils.logging.Logger;

import java.io.IOException;
import java.net.URLEncoder;
import java.nio.charset.StandardCharsets;
import java.util.List;


Expand Down Expand Up @@ -153,9 +155,11 @@ public String translate(String sourceText, String sourceLang,
url.append("translate?api-version=").append(apiVersion);
if (!"auto".equals(from))
{
url.append("&from=").append(from);
url.append("&from=").append(
URLEncoder.encode(from, StandardCharsets.UTF_8));
}
url.append("&to=").append(to);
url.append("&to=").append(
URLEncoder.encode(to, StandardCharsets.UTF_8));

Gson gson = new GsonBuilder().disableHtmlEscaping().create();
JsonArray body = new JsonArray();
Expand Down
15 changes: 8 additions & 7 deletions src/main/java/org/jitsi/jigasi/transcription/LibreTranslateTranslationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import com.google.gson.Gson;
import com.google.gson.GsonBuilder;
import com.google.gson.JsonObject;
import org.apache.http.HttpResponse;
import org.apache.http.client.methods.HttpPost;
import org.apache.http.entity.ContentType;
Expand Down Expand Up @@ -99,13 +100,13 @@ private static String getPrimaryLanguageCode(String language)
@Override
public String translate(String sourceText, String sourceLang, String targetLang)
{
String payload = "{"
.concat("\"q\": \"" + sourceText + "\",")
.concat("\"source\": \"" + getPrimaryLanguageCode(sourceLang) + "\",")
.concat("\"target\": \"" + getPrimaryLanguageCode(targetLang) + "\",")
.concat("\"format\": \"text\",")
.concat("\"api_key\": \"\"")
.concat("}");
JsonObject payloadObject = new JsonObject();
payloadObject.addProperty("q", sourceText);
payloadObject.addProperty("source", getPrimaryLanguageCode(sourceLang));
payloadObject.addProperty("target", getPrimaryLanguageCode(targetLang));
payloadObject.addProperty("format", "text");
payloadObject.addProperty("api_key", "");
String payload = new GsonBuilder().disableHtmlEscaping().create().toJson(payloadObject);

StringEntity entity = new StringEntity(payload, ContentType.APPLICATION_JSON);

Expand Down
Loading