feat(transcription): add Microsoft Translator service - #636
Conversation
|
How have you tested this if you don't have maven? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #636 +/- ##
============================================
- Coverage 19.14% 19.02% -0.12%
Complexity 310 310
============================================
Files 83 84 +1
Lines 7204 7268 +64
Branches 958 966 +8
============================================
+ Hits 1379 1383 +4
- Misses 5596 5655 +59
- Partials 229 230 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Very efficiently: Before Maven was available locally, I validated the new service outside the Maven lifecycle as follows:
I have now also run |
|
Have you signed the CLA as I cannot find it? |
I have signed it now. |
|
Hum, I still don't see it. |
And now? |
|
Thank you |
Summary
Adds
BingTranslationService, a newTranslationServiceimplementation backed by the Microsoft Translator Text API v3.The service is selected through the existing
org.jitsi.jigasi.transcription.translationServiceproperty, so no changes toTranscriberare required.New configuration properties:
org.jitsi.jigasi.transcription.bing.subscription_keyorg.jitsi.jigasi.transcription.bing.subscription_regionorg.jitsi.jigasi.transcription.bing.endpoint(defaults tohttps://api.cognitive.microsofttranslator.com)org.jitsi.jigasi.transcription.bing.api_version(defaults to3.0)The PR also adds commented sample configuration to
jigasi-home/sip-communicator.propertiesand documents the provider inREADME.md.Rationale
Microsoft Translator supports Upper Sorbian (
hsb) and Lower Sorbian (dsb) in addition to common languages such as German and English. That makes it useful for deployments that need Sorbian translation without chaining through a separate pivot-language backend.Test plan
mvn verifylocally with Maven 3.9.15 and Java 17; the build passed, including Checkstyle with 0 violations.