fix(printer): don't wrap broken when-guards in parentheses - #1018
Open
braxtonzhangio wants to merge 5 commits into
Open
fix(printer): don't wrap broken when-guards in parentheses#1018braxtonzhangio wants to merge 5 commits into
braxtonzhangio wants to merge 5 commits into
Conversation
added 5 commits
August 8, 2026 14:56
Signed-off-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com>
Signed-off-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com>
Signed-off-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com>
Signed-off-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com>
Signed-off-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With a narrow
printWidth,whenguards in switch rules wrapped the expression in parentheses (when ( … )). Those parens are unnecessary for Java pattern guards and look noisy next to the trailing->.Changes
whenguards by breaking/indenting the expression instead of usingifBreak("(" / ")").printWidth: 40).Test plan
npm test(or the repo’s usual unit-test command fortest/unit-test)switch-when-guard-parensmatches expected outputFixes #1001