Use unified build status key with exclude origin PR Branches strategy

[JeanChristopheMorinPerso]

…r filter is used.

Little improvement in the way the build status key is named when the Discover branch option is set to Exclude branches that are also filed as PRs. With these changes, the build key for a branch that then goes into PR will stay the same (<project_name>/<branch_name>), like it is for any branch right now.

I tested all possible options of the discover branch and my change is really only affecting the build key when Exclude branches that are also filed as PRs is chosen.

This should hopefully fix #160. I also hope it will be more solid than #147.

I'm not a Java developer, and so I did my best with the knowledge I have to keep the code style. Let me know if there is anything to change.

[jetersen]

@JeanChristopheMorinPerso I think it would be better to just pass the bitbucketsource that is already defined in sendNotifications method and pass to createStatus

[jetersen]

I have gone ahead and added my suggestion, please feel free to review it :)

[JeanChristopheMorinPerso]

Thanks a lot @Casz , it looks much nicer now. I'll test the changes later today (even if not much change from my changes). I really appreciate the time you took to improve the PR! :)

[JeanChristopheMorinPerso]

I'll fix the build. Looks like one import is wrongly ordered.

[jetersen]

@JeanChristopheMorinPerso fixed 👍

[JeanChristopheMorinPerso]

Looks like you are faster than me 😄 Tested the latest changes and everything looks good 👍

[JeanChristopheMorinPerso]

@Casz Do you a time frame for when the next release will happen? Don't want to be pushy or anything... It's more by curiosity.

[jetersen]

Would be great if I could land this, #173 and #174 together in next release 😄

[jetersen]

I'll see if I can land the PRs myself in the weekend

[JeanChristopheMorinPerso]

Thanks!

[timshadel]

@Casz Any update on getting this PR in and released? It'd really help us out! 😄

[jetersen]

Time did not allow me to work on this :|
Since the authors PR of #173 and #174 is not willing to listen to PR reviews, I have to do the work myself.

[JeanChristopheMorinPerso]

Thank you @Casz ! I really appreciate the time you took to improve the work I initially did on this PR :)

I'm sure a lot of other people will be happy to see this feature finally released.