Skip to content

feat(config): added support for per-slide next_terminates_loop. - #699

Open
saikat709 wants to merge 2 commits into
jeertmans:mainfrom
saikat709:feat/per-slide-next-terminates-loop
Open

saikat709 wants to merge 2 commits into
jeertmans:mainfrom
saikat709:feat/per-slide-next-terminates-loop

Conversation

@saikat709

Copy link
Copy Markdown
Contributor

Fixes Issue

Closes #436

Description

Added support for configuring next_terminates_loop per slide via next_slide(next_terminates_loop=True) in Python slide code. When enabled for a slide, pressing next or advancing will wait for the current loop iteration to finish before proceeding to the next slide.

Check List

Check all the applicable boxes:

  • I understand that my contributions needs to pass the checks;
  • If I created new functions / methods, I documented them and add type hints;
  • If I modified already existing code, I updated the documentation accordingly;
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions Bot added waiting review Waiting review (or response) by a maintainer waiting triage This issue or PR needs to be labeled accordingly. labels Sep 18, 2026
@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 2 high

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category Results
ErrorProne 2 high

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.88%. Comparing base (df0f1f1) to head (b662762).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   78.87%   78.88%           
=======================================
  Files          23       23           
  Lines        2230     2231    +1     
=======================================
+ Hits         1759     1760    +1     
  Misses        471      471           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikat709
saikat709 force-pushed the feat/per-slide-next-terminates-loop branch 2 times, most recently from 7f2bccc to 2089770 Compare September 18, 2026 18:28
@saikat709
saikat709 force-pushed the feat/per-slide-next-terminates-loop branch from 2089770 to 6afefbc Compare September 18, 2026 18:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting review Waiting review (or response) by a maintainer waiting triage This issue or PR needs to be labeled accordingly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow for waiting until loop is complete before switching slide

1 participant