Repository navigation
feat(convert): add presentation shortcuts to replay slide, toggle controls, and show help - #694
Closed
ajlaanayan-crypto wants to merge 5 commits into
Closed
ajlaanayan-crypto wants to merge 5 commits into
ajlaanayan-crypto wants to merge 5 commits into
Conversation
…trols, and show help
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 78.87% 78.87%
=======================================
Files 23 23
Lines 2230 2230
=======================================
Hits 1759 1759
Misses 471 471 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Ref #610
Description
This PR adds interactive keyboard shortcuts to Reveal.js presentation templates as discussed in #610:
Rkey (keyCode: 82): Replay current slide animation from the beginning (currentTime = 0; play()).Ckey (keyCode: 67): Toggle native video scrubber controls on the active slide to easily scrub through animations.?key (keyCode: 191): Toggle the Reveal.js keyboard shortcuts help modal.Also:
firebase_sync.htmlviascripts/sync_firebase_template.py.docs/source/_static/template.html.test_revealjs_keybindingsintests/test_convert.py.Check List
Note to reviewers
All tests pass locally (
pytest: 238 passed, 1 skipped). Template parity is verified.