Skip to content

feat(convert): add presentation shortcuts to replay slide, toggle controls, and show help - #694

Closed
ajlaanayan-crypto wants to merge 5 commits into
jeertmans:mainfrom
ajlaanayan-crypto:feat/reveal-keyboard-shortcuts
Closed

ajlaanayan-crypto wants to merge 5 commits into
jeertmans:mainfrom
ajlaanayan-crypto:feat/reveal-keyboard-shortcuts

Conversation

@ajlaanayan-crypto

Copy link
Copy Markdown
Contributor

Fixes Issue

Ref #610

Description

This PR adds interactive keyboard shortcuts to Reveal.js presentation templates as discussed in #610:

  1. R key (keyCode: 82): Replay current slide animation from the beginning (currentTime = 0; play()).
  2. C key (keyCode: 67): Toggle native video scrubber controls on the active slide to easily scrub through animations.
  3. ? key (keyCode: 191): Toggle the Reveal.js keyboard shortcuts help modal.

Also:

  • Synchronized firebase_sync.html via scripts/sync_firebase_template.py.
  • Updated documentation template in docs/source/_static/template.html.
  • Added unit test test_revealjs_keybindings in tests/test_convert.py.

Check List

  • I understand that my contributions need to pass the checks;
  • If I created new functions / methods, I documented them and added type hints;
  • If I modified already existing code, I updated the documentation accordingly;
  • The title of my pull request is a short description of the requested changes.

Note to reviewers

All tests pass locally (pytest: 238 passed, 1 skipped). Template parity is verified.

@github-actions github-actions Bot added waiting review Waiting review (or response) by a maintainer waiting triage This issue or PR needs to be labeled accordingly. labels Sep 11, 2026
@codacy-production

codacy-production Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.87%. Comparing base (5e71dd5) to head (4672480).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #694   +/-   ##
=======================================
  Coverage   78.87%   78.87%           
=======================================
  Files          23       23           
  Lines        2230     2230           
=======================================
  Hits         1759     1759           
  Misses        471      471           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot removed waiting triage This issue or PR needs to be labeled accordingly. waiting review Waiting review (or response) by a maintainer labels Sep 11, 2026
@ajlaanayan-crypto
ajlaanayan-crypto deleted the feat/reveal-keyboard-shortcuts branch September 11, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants