Repository navigation
fix(convert): typo in RevealTheme member name (soralized -> solarized) - #692
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
Hi @jeertmans! I've updated the PR to address all CI checks:
All |
|
Hi @ajlaanayan-crypto, thanks for the PR, but why are the commits not from you, but from @shuryansmishra? |
i am really sorry thats from my another username i am fixing it, i already fix that |
34c4466 to
a7a51c2
Compare
|
i have one more suggestion can can i write readme more interactive i can more components like graphs and everything . |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
=======================================
Coverage 79.09% 79.09%
=======================================
Files 23 23
Lines 2215 2215
=======================================
Hits 1752 1752
Misses 463 463 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks @ajlaanayan-crypto! Could you add an entry to the changelog documenting your contribution? |
Please open another issue or PR for this :-) |
|
Hi @jeertmans! I've added an entry to I also fixed the type-checking error on Regarding the README improvements, I'll open a separate issue/PR for that as suggested. Thank you! |
| - Fixed typo in `RevealTheme` member name where `solarized` was misspelled as `soralized`. | ||
| [@ajlaanayan-crypto](https://github.com/ajlaanayan-crypto) [#692](https://github.com/jeertmans/manim-slides/pull/692) |
There was a problem hiding this comment.
Contributions are listed by chronological order: can you put yours at the end of the "Fixed" list?
There was a problem hiding this comment.
yes sure i have done it
Fixes Issue
Closes #691
Description
Fixes a typo in
RevealThemeenum inmanim_slides/convert.pywhere member namesoralizedwas misspelled instead ofsolarized.Added a unit test
test_reveal_theme_membersintests/test_convert.pyto ensure allRevealThemeenum member names match their values.Check List
Check all the applicable boxes:
Screenshots
N/A
Note to reviewers
All tests pass locally (
pytest tests/test_convert.pyand full test suite: 238 passed, 1 skipped).