Skip to content

fix(convert): typo in RevealTheme member name (soralized -> solarized) - #692

Merged
jeertmans merged 7 commits into
jeertmans:mainfrom
ajlaanayan-crypto:fix/reveal-theme-solarized-typo
Sep 11, 2026
Merged

jeertmans merged 7 commits into
jeertmans:mainfrom
ajlaanayan-crypto:fix/reveal-theme-solarized-typo

Conversation

@ajlaanayan-crypto

Copy link
Copy Markdown
Contributor

Fixes Issue

Closes #691

Description

Fixes a typo in RevealTheme enum in manim_slides/convert.py where member name soralized was misspelled instead of solarized.

Added a unit test test_reveal_theme_members in tests/test_convert.py to ensure all RevealTheme enum member names match their values.

Check List

Check all the applicable boxes:

  • I understand that my contributions needs to pass the checks;
  • If I created new functions / methods, I documented them and add type hints;
  • If I modified already existing code, I updated the documentation accordingly;
  • The title of my pull request is a short description of the requested changes.

Screenshots

N/A

Note to reviewers

All tests pass locally (pytest tests/test_convert.py and full test suite: 238 passed, 1 skipped).

@github-actions github-actions Bot added waiting review Waiting review (or response) by a maintainer waiting triage This issue or PR needs to be labeled accordingly. labels Sep 10, 2026
@codacy-production

codacy-production Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ajlaanayan-crypto

Copy link
Copy Markdown
Contributor Author

Hi @jeertmans!

I've updated the PR to address all CI checks:

  1. Replaced the assert statement in test_reveal_theme_members with an explicit check to satisfy Codacy's security analysis.
  2. Resolved the recent Ruff linter failures from the latest pre-commit autoupdate (# noqa: C901 on concatenate_video_files and removed the unused tmp_dir in tests/test_utils.py).

All pre-commit.ci and Codacy checks are now green. Ready for your review whenever you have time! Thanks!

@jeertmans

Copy link
Copy Markdown
Owner

Hi @ajlaanayan-crypto, thanks for the PR, but why are the commits not from you, but from @shuryansmishra?

@ajlaanayan-crypto

ajlaanayan-crypto commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor Author

Hi @ajlaanayan-crypto, thanks for the PR, but why are the commits not from you, but from @shuryansmishra?

i am really sorry thats from my another username i am fixing it, i already fix that

@ajlaanayan-crypto
ajlaanayan-crypto force-pushed the fix/reveal-theme-solarized-typo branch from 34c4466 to a7a51c2 Compare September 11, 2026 00:46
@ajlaanayan-crypto

Copy link
Copy Markdown
Contributor Author

i have one more suggestion can can i write readme more interactive i can more components like graphs and everything .

@jeertmans jeertmans changed the title fix(convert): fix typo in RevealTheme member name (soralized -> solarized) fix(convert): typo in RevealTheme member name (soralized -> solarized) Sep 11, 2026
@codecov

codecov Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.09%. Comparing base (6b276c4) to head (a7a51c2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files          23       23           
  Lines        2215     2215           
=======================================
  Hits         1752     1752           
  Misses        463      463           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeertmans

Copy link
Copy Markdown
Owner

Thanks @ajlaanayan-crypto! Could you add an entry to the changelog documenting your contribution?

@jeertmans

Copy link
Copy Markdown
Owner

i have one more suggestion can can i write readme more interactive i can more components like graphs and everything .

Please open another issue or PR for this :-)

@ajlaanayan-crypto

Copy link
Copy Markdown
Contributor Author

Hi @jeertmans!

I've added an entry to CHANGELOG.md under the ### Fixed section documenting this fix with my username and PR link.

I also fixed the type-checking error on os.startfile so all checks and pre-commit.ci are now completely green.

Regarding the README improvements, I'll open a separate issue/PR for that as suggested. Thank you!

Comment thread CHANGELOG.md Outdated
Comment on lines +37 to +38
- Fixed typo in `RevealTheme` member name where `solarized` was misspelled as `soralized`.
[@ajlaanayan-crypto](https://github.com/ajlaanayan-crypto) [#692](https://github.com/jeertmans/manim-slides/pull/692)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributions are listed by chronological order: can you put yours at the end of the "Fixed" list?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sure i have done it

@jeertmans jeertmans left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeertmans jeertmans added html-convert Related to converting to HTML slides and removed waiting triage This issue or PR needs to be labeled accordingly. waiting review Waiting review (or response) by a maintainer labels Sep 11, 2026
@jeertmans
jeertmans merged commit 5e71dd5 into jeertmans:main Sep 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

html-convert Related to converting to HTML slides

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Typo in RevealTheme enum: "soralized" should be "solarized"

2 participants