Repository navigation
Improve demo GIF for better visualization - #620
JasmineSavathallapalli wants to merge 2 commits into
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 1 minor |
TIP This summary will be updated as you push new changes. Give us feedback
|
Hi @JasmineSavathallapalli, thanks for your contribution! I think it's much better. However, I liked to see the key presses in the recording, as it really show that it's more than just one single video. On Linux, you can use (for example) screenkey to show key presses. |
There was a problem hiding this comment.
You shouldn't change this: we need to use the HTTPS path for the GIF to appear on PyPI.
|
|
Hi @jeertmans, thank you for the feedback! I understand that the key presses should be visible in the demo. I’m currently trying to recreate the GIF with key press visualization, but I’m facing some issues setting it up on my system. I’m working on fixing it and will update the PR soon. |
No worries! If you find an alternative clean way to show key presses, that's also fine. |
|
Closing as stalled PR for a long time. |
Improved the demo GIF to better showcase the features of manim-slides.
Fixes #38